humhub / reportcontent

This module allows users to report posts to space and super admins.
15 stars 15 forks source link

Groups owners or moderators can't see reports #80

Open ilMagnifico opened 3 months ago

ilMagnifico commented 3 months ago

The report module doesn’t work as advertised. Only the system administrator (currently me) receives the reports, not group owners or group moderators.

marc-farre commented 3 months ago

For non-system admin users, they need to be an owner, admin or moderator of the space. Then, they'll be notified about reported content from this space.

However, there is an exception:

If we report a space admin post, we create a system admin only report (only visible in admin area)

See https://github.com/humhub/reportcontent/blob/master/models/ReportContent.php#L97

@luke- I think this adds confusion, mainly when testing the module to understand how it works. Shouldn't we remove it?

luke- commented 3 months ago

@Semir1212 What do you think?

ilMagnifico commented 3 months ago

I've done lots of tests, including deleting the module and re-installing it. I've reported things as admin, as a regular member and both in spaces of my own and other spaces. Even when I go to the "Reported content" tab which pops up for space owners when the reporting module is activated, there is nothing there on that tab. It just says that things will show up here if someone reports something.

Semir1212 commented 3 months ago

@luke- @marc-farre I think there should be a way for users to report content from space admins. The behaviour is explained in the manual. Maybe we could create one report for the space admin an one for the sys admin? If not, I would leave it as is.

marc-farre commented 3 months ago

I've done some tests by reporting a post in a space:

  1. Report about a post created by an admin of the space: the users member of the global "Administrators" group are notified (not the space admins and moderators)
  2. Report about a post created by a member of the space: the admins and moderators of the space are notified (not the global "Administrators" group members)

So this is the current behavior of the module, and it's working with the Report Content module version 1.1.0.

@Semir1212 so do you agree, for the case n°1 (reporting a post created by a space admin), we should also notify all space admins and moderators (in addition to the global "Administrators" group members)?

ilMagnifico commented 3 months ago

This is the kind of explanation that would have been useful in the description of the module. We like what we've seen and are grateful you guys put so much time and effort into developing this.

Semir1212 commented 3 months ago

@marc-farre Yes, as long as the sys admins are also notifed and the space admins can not remove the report by themselves.

ArchBlood commented 2 months ago

Currently testing for this issue;

  1. Global content i.e. posts made directly on profile streams can't be viewed by those that aren't a system admin if reported, I believe this is because of Manage Module permissions, but even if you do have this permission you'll get "You are not permitted to access this section." error message because you also need the Manage Settings permissions as well;
  2. Space Moderators & Owners can view and manage reported content within the Space stream and on the dashboard as long as the permissions are met;

The only issues that I'm seeing is no notifications are sent to owner/administrators or moderators and both Space & Global reports aren't filtered so whatever is reported in a Space also is sent to Global but I'd also like to note that point 1 also can be considered an issue as well here.

My idea when it comes to the logic that needs done here is as followed;

ilMagnifico commented 3 days ago

Again, this is the situation:

Screenshot 2024-09-04 alle 19 55 01

I'm a mod of the space A.

People reports 2 different posts of that spaces of two different users with not any kind of permits, so normal users, just for test.

Screenshot 2024-09-04 alle 19 54 42

I can see them on the Admin page

Screenshot 2024-09-04 alle 19 32 22

But when I try to have a look at them it doesn't work.

This must be sure a bug. I mean otherwise what's the point of being a Mod of a Space if then you can't even see reports from users on that space?