humhub / rest

HumHub Rest API Module
24 stars 24 forks source link

User Account: Add `authclient`, `authclient_id`. #106

Closed luke- closed 1 year ago

luke- commented 1 year ago

https://github.com/humhub/rest/blob/master/definitions/UserDefinitions.php#L51

These are also to be returned.

This should find the user by the parameters name of the authclient (user.auth_mode) and id value of user.authclient_id.

yurabakhtin commented 1 year ago

@luke- PR https://github.com/humhub/rest/pull/111: Please note on previous version the core scenario User::SCENARIO_EDIT_ADMIN was used from REST API side for add and update user, in order to don't touch the core scenario I decided to extend the model User from REST module side with new model ApiUser. If you don't like such wrapper/extenssion please let me know, and otherwise we should modify a core side in order to either add fields into the existing scenario or create new one with name like SCENARIO_API_REQUEST = 'apiRequest, but I am not sure it is a good idea to mix a code from module with core code.

luke- commented 1 year ago

@yurabakhtin Thanks, the Wrapper Solution is good in this case.