search

humhub / tasks

Intuitive task management tool with many basic and advanced features.
23 stars 34 forks source link

Fix Tests #181

Closed luke- closed 2 years ago

s-tyshchenko commented 2 years ago

All tests passed on master branch.

luke- commented 2 years ago

@s-tyshchenko Hmm, can you please check here on github?

image

luke- commented 2 years ago

@yurabakhtin Can you please look again?

yurabakhtin commented 2 years ago

@luke- I just replaced php 7.3 with 7.4 on the tests - https://github.com/humhub/tasks/pull/183/commits/9c41c178d10963666edaa8276b0754d321ff6028.

yurabakhtin commented 2 years ago

@luke- PHP 7.3 doesn't work correctly on develop version 1.11 because here https://github.com/humhub/humhub/commit/bb417da#diff-b0143204392e87bf27a8e461e98be6aba41b271e27f0186c04afb80e6cade955R156 I updated methods from serialize() and unserialize() to magic methods __serialize() and __unserialize(), It is why we see errors like [Exception] Serialization of 'Closure' is not allowed on php7.3+develop.

Do you think we should find a solution to keep supporting php 7.3 together with 8.1 on HumHub version 1.11?

luke- commented 2 years ago

@yurabakhtin Ok, then let's drop support for 7.3 in HumHub 1.11