search

humhub / translation

Internal translation tool
https://translate.humhub.org
Apache License 2.0
17 stars 15 forks source link

JA - Translate Issue #67

Closed luke- closed 3 weeks ago

luke- commented 3 weeks ago

Related: https://translate.humhub.org/s/ja/?contentId=96199&commentId=1177

yurabakhtin commented 3 weeks ago

@luke-

Problem 1

It was fixed and merged here https://github.com/humhub/translator/issues/48.

Problem 2

It should be fixed by the old PR https://github.com/humhub/translation/pull/42, it was not merged, also I see the module has no releases and it seems the CHANGELOG.md file should be updated to keep only version 1.0.1 if it was not released or keep only 1.0.2 to void some errors on updating.

Please wait the merging until I will fix the tests there.

I confirm the problem 2 exists on master because the module "Custom Pages" has the folder name as custom-pages but id as custom_pages, so the translation module cannot find the message files. It works well on the PR #42: fixed-translation

luke- commented 3 weeks ago

@yurabakhtin Doh, I just merged it ;-)

luke- commented 3 weeks ago

*Thought the error was related to an old base

yurabakhtin commented 3 weeks ago

@luke-

*Thought the error was related to an old base

The error was in the new code from the merged PR #42, please merge new fix https://github.com/humhub/translation/pull/68.

luke- commented 3 weeks ago

Ok, just merged #68 and applied on the translation site.

Can you confirm the issue is fixed?

yurabakhtin commented 3 weeks ago

@luke-

Can you confirm the issue is fixed?

Yes, I confirm that I could reproduce the bug on master before, and then after applying the fix PR #42 I see it works as my screenshot above.

I forgot to inform that I have detected 3 modules which has the char - in folder name but _ in module id:

also one module external_calendar has _ in id and in folder name.

Probably they all should be renamed to - for id and folder to avoid such conflicts in future.

luke- commented 3 weeks ago

@yurabakhtin Thanks.

Good point. I've created an issue here: https://github.com/humhub/humhub-internal/issues/359 - But it has no prio at the moment.