search

humhub / twofa

Increase security within your network by adding an additional authentication method besides username and password.
4 stars 5 forks source link

Button "Log out" doesn't prevent pjax #29

Closed yurabakhtin closed 3 years ago

yurabakhtin commented 3 years ago

@luke- Why did you modified the button "Log out" here https://github.com/humhub/twofa/commit/7375d22#diff-6b50c5c79652c49abaff914c86163ba66bb7e98736f436d6d440a588b365ab6aR45 ?

button_logout

At least the attribute 'data-pjax' => false is wrong, because correct is 'data-pjax-prevent' => 1.

yurabakhtin commented 3 years ago

@luke-

At least the attribute 'data-pjax' => false is wrong, because correct is 'data-pjax-prevent' => 1.

PR https://github.com/humhub/twofa/pull/30

luke- commented 3 years ago

@yurabakhtin Thanks!