humio / atom-elm-format

Run elm-format in atom
https://atom.io/packages/elm-format
Apache License 2.0
10 stars 8 forks source link

Update README on installation and configuration #17

Closed johanbrook closed 7 years ago

johanbrook commented 7 years ago

I had to go through the source to see that I need to config an absolute path to elm-format, so I made a suggestion for the README.

Sidenote: shouldn't it be easy to add a settings panel in Atom for this? I can see the settings.js file but no option in Atom for showing package settings.

benjick commented 7 years ago

Hey, thanks for the PR!

Are you not seeing this panel?

screen shot 2017-01-21 at 11 54 09
benjick commented 7 years ago

@johanbrook I'm closing this, let me know if you still think it should be in the README

benjick commented 7 years ago

Also changed the default binary path to elm-format to path instead of relying on a hard-coded value