search

humio / issues

Issue Tracker for Humio
4 stars 2 forks source link

Escape result values in links #35

Closed Crevil closed 6 years ago

Crevil commented 6 years ago

When grouping results a link to a query is generated to the events related to the group.

If the results contain a " they are not escaped when inserted into the query.

With events with msg field:

Some id "id" did something cool
Some id "id" did something bad

When grouping by msg:

groupby(msg)

The result is:

msg                              _count
Some id "id" did something cool  1
Some id "id" did something bad   1

When clicking the links on each message group the resulting query becomes

groupby(msg) | "msg"="Some id "id" did something cool"
pmech commented 6 years ago

Thanks! We'll look into this

anagrius commented 6 years ago

I will try to fix this on monday. Should be a quick one. I guess it is only double quotes that are impacted right? No other special characters we can think of?

Crevil commented 6 years ago

I believe so

lør. 13. jan. 2018 kl. 00.13 skrev Thomas Anagrius <notifications@github.com

:

I will try to fix this on monday. Should be a quick one. I guess it is only double quotes that are impacted right? No other special characters we can think of?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/humio/issues/issues/35#issuecomment-357380034, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkBntTBn-MhHWk0R3S494LvyT2i0jv3ks5tJ-b9gaJpZM4RURxN .

-- Hilsen Bjørn Sørensen Tlf.: (+45) 28447177

anagrius commented 6 years ago

Sorry, I only just started looking at this now. Should be included in the next release

anagrius commented 6 years ago

This was actually also a problem for fields with names containing spaces.

It is fixed now and will be part of the next release.

Crevil commented 6 years ago

Sounds great. Thank you for the quick fixes, it makes our lives easy! 💪🙌

ons. 17. jan. 2018 kl. 15.13 skrev Thomas Anagrius <notifications@github.com

:

This was actually also a problem for fields with names containing spaces.

It is fixed now and will be part of the next release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/humio/issues/issues/35#issuecomment-358316165, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkBngq06qIOeoC_QJe4RgjpLRSkSQwsks5tLf_mgaJpZM4RURxN .

-- Hilsen Bjørn Sørensen Tlf.: (+45) 28447177