humlab-sead / sead_browser_client

Online browser client for the SEAD database
2 stars 0 forks source link

Soil chemistry axis labels missing #321

Open MattiasSealander opened 5 months ago

MattiasSealander commented 5 months ago

The soil chemistry lacks labels/titels for the Y and X axis (example below).

A user unfamiliar with MAL wouldn't be able to tell from the graphics what an axis represents; samples, proportion (%), or something else?

The image below (from browser.sead.se) is a LOI graphic from site 1, Slöinge Raä 114. It is not apparent that the values are proportions before hovering over them with the mouse, which is a great feature on its own. The vertical axis should show that these are percentages, however, and the horizontal axis that they are samples.

The addition of material/weight to one sample is also interesting (- percent). May need checking. bild

The same is true for phosphates. Which currently lacks any vertical axis, and hovering with mouse only shows sample name. Will talk with Johan L regarding how vertical axis should be labelled. bild

MattiasSealander commented 5 months ago

After discussing with Johan L quickly this is what he had to comment:

For MS:

For phosphates:

johanvonboer commented 3 months ago

Thanks for the report!

I have added labels to the LOI chart axes, and also to the horizontal axis of the phosphate chart. Will push this to supersead in the near future.

Regarding the name of the instrument in the MS chart, I think that is a good idea, but I don't think it exists in the database. At least I can't remember ever coming across that.

About the phosphates method, that information is available in the tooltip: image

But it's worth thinking about including it above the chart as well, since it's pretty well hidden as it is now. Or perhaps I'll make it into a button next to Reference, to increase the visibility of it at least a little bit. What do you think?

Regarding the units, if we want to use "CitP - ppm P" as the unit for phosphate degrees from MAL then I would prefer it if we could get that into the database, which would be the proper way of doing it. I don't want to hard-code it into the webclient since I'm guessing it's theoretically possible that some other lab could provide us with phosphate data that should have a different unit?

In general, it's great to get some feedback on these things, I don't really know what information is necessary to show and in what way for a researcher to be able to use it effectively.