search

humlab-sead / sead_change_control

Sane SEAD change control using Sqitch.
1 stars 0 forks source link

10 meter ceramic shards #107

Closed johanvonboer closed 6 months ago

johanvonboer commented 1 year ago

In site 3540: https://browser.sead.se/site/3540

We have ceramic shards labeled as 'Kärl' that is 10 meters in size?? I suspect the wrong unit of measurement is being used. image

MattiasSealander commented 1 year ago

Yes, most likely the id used in import was set wrong, either by excel shenanigans or by myself. Will investigate if it is one off or consistent and add to pile of updates.

MattiasSealander commented 9 months ago

I looked this up and I am wondering where the data is fetched from and how.

I put together a query below for the sample in the screenshot and that shows the unit of measurements as millimetres:

SELECT ps.physical_sample_id, ps.sample_name, st.type_name, d.dimension_name, sd.dimension_value, u.unit_name

FROM tbl_physical_samples ps JOIN tbl_sample_types st ON ps.sample_type_id = st.sample_type_id JOIN tbl_sample_dimensions sd ON ps.physical_sample_id = sd.physical_sample_id JOIN tbl_dimensions d ON sd.dimension_id = d.dimension_id JOIN tbl_units u ON d.unit_id = u.unit_id

Where ps.sample_name like '4751@1@Kärl'

johanvonboer commented 9 months ago

You're right, the database is correct and I see now that I have made a mistake in how I fetch this data.

I am currently doing tbl_physical_samples => tbl_sample_dimensions => tbl_methods => tbl_units

But I should be doing tbl_physical_samples => tbl_sample_dimensions => tbl_dimensions => tbl_units

So I'm fetching the unit based on the method, when I should be fetching it based on the dimension.

I will correct this ASAP.

MattiasSealander commented 6 months ago

Has this been fixed so we can close this issue?

johanvonboer commented 6 months ago

It was semi-fixed, but it is fully fixed now, so yes we can close this.