humlab-sead / sead_change_control

Sane SEAD change control using Sqitch.
1 stars 0 forks source link

Sampling methods contains lots of "Temp record" #126

Open Maanin00 opened 1 year ago

Maanin00 commented 1 year ago

Describe the bug Sampling methods contains more than 20% "Temp record". Does not look good in production.

bild

To Reproduce Steps to reproduce the behavior: Just open https://supersead.humlab.umu.se/

Expected behavior Those instances with "temp record" as sampling method should be reviewed. Is it possible to ad the correct methods?

SQL If applicable, add SQL to help explain your problem.

Additional context Add any other context about the problem here.

johanvonboer commented 1 year ago

Ta reda på vad det är för data och ta sedan kontakt med @visead för att utreda hur vi gör.

johanvonboer commented 1 year ago

@johanvonboer provide the sql for this from JAS.

johanvonboer commented 1 year ago

There is no JAS SQL since the JAS server is doing this through a MongoDB pipeline, but here's SQL for selecting all the sites and sample groups with this method:

SELECT 
tbl_methods.method_id,
tbl_methods.method_name,
tbl_sample_groups.sample_group_id,
tbl_sample_groups.site_id
FROM tbl_methods
JOIN tbl_sample_groups ON tbl_sample_groups.method_id=tbl_methods.method_id
WHERE tbl_methods.method_name='Temporary record'
Maanin00 commented 1 year ago

Så vitt jag kan se är det bara Bugs-data det gäller:

bild

(Är "Master dataset" alltid definierat stämmer det antagandet.)

johanvonboer commented 1 year ago

@rebeckahw ändrar till 'Unknown'.