humlab-sead / sead_change_control

Sane SEAD change control using Sqitch.
1 stars 0 forks source link

20200203_DML_FACET_UI_ELEMENTS_UPDATE: Correct Filter group and item titles #37

Closed visead closed 2 years ago

visead commented 4 years ago

Correct filter visible elements as follows:

measured_values - measurements MS -Magnetic sus. LOI - Loss on Ignition PT? - Phosphates

space_time - space/time Site - Sites Country - Countries Sample group - Sample groups

Taxa - Taxon

Reorder filter groups: space/time ecology measurements taxonomy

Reorder items within space/time filter Master datasets Countries Sites Sample groups Time periods Geochronology

johanvonboer commented 4 years ago

Since this definition is now stored in the database it's more of a db change issue so I'm moving it to that repository. I think we also need to create a sorting column in the db, I suggest we call it display_sort_weight or menu_sort_weight, to avoid creating confusion with the existing sort_expr column.

visead commented 4 years ago

Is this solvable though [https://github.com/humlab-sead/sead_query_api/issues/53#issuecomment-567436980]? (sorry, don't know how to link between repositories!)

roger-mahler commented 4 years ago

Partly already resolved by humlab-sead/sead_query_api/issues/53 which adds a facet JSON propery that describes the group.

roger-mahler commented 4 years ago

See 20200203_DML_FACET_UI_ELEMENTS_UPDATE which resolves part of this issue.

johanvonboer commented 4 years ago

Still lacks sort order. Would like to have integers on both the groups and filters which denotes sort order.