search

humlab-sead / sead_query_api

.NET Core port of Query SEAD API
Other
2 stars 0 forks source link

Faulty facet: Restricted facet with non-enforced constraint #87

Closed roger-mahler closed 7 months ago

roger-mahler commented 4 years ago

This unit test fails since number of constraints are higher than expected number.

https://github.com/humlab-sead/sead_query_api/blob/480545e64789dc6db80f813b13cc5a435c6d39b4/sead.query.test/UnitTests/QueryBuilder/QuerySetupBuilderTests.cs#L58

This is an old facet previously not exposed by the query engine. A reasonable behavior would be to enforce the constraint for all facets that are specified as a subset of the underlying source. Recent changes in the facet engine enables constraints to be enforced.

roger-mahler commented 4 years ago

On second thought, this might be a policy in the query engine that is open for discussion. Should a facet, without picks, filter data in following facets based on the implicit constraint given by the facet's specification? Or should it be dormant as long as no user picks have been made? The implicit filtering seems obvious e.g. a facet "Sweden" with only Swedish sites, should filter out non-Swedish sites even if no selection is made.

roger-mahler commented 7 months ago

Closing for now.