humlab-speech / superassp

A wrassp super-package that re-exports all the functionality of wrassp, and adds the ability to get Praat and MATLAB signals into SSFF format.
https://humlab-speech.github.io/superassp/
2 stars 1 forks source link

Fix windowshift issues in python f0 functions #26

Closed FredrikKarlssonSpeech closed 2 years ago

FredrikKarlssonSpeech commented 2 years ago

The windowShift is used for getting start time, but is not an argument to the program:

── Error (test_python.R:15:5): Confirm that harvest can generate valid SSFF files ──
Error: object 'windowSize' not found
Backtrace:
 1. base::do.call(f, list(listOfFiles = testFile, toFile = FALSE))
      at test_python.R:15:4
 2. superassp::harvest(...)

── Error (test_python.R:15:5): Confirm that dio can generate valid SSFF files ──
Error: object 'windowSize' not found
Backtrace:
 1. base::do.call(f, list(listOfFiles = testFile, toFile = FALSE))
      at test_python.R:15:4
 2. superassp::dio(listOfFiles = "../signalfiles/msajc003.wav", toFile = FALSE)

Both Harvest and DIO computes times, so I should use that information instead: