search

hummatli / AppCrossPromoter

📦🐎 An android library to cross-promote your apps and manage direct-sold campaigns (free, open source, third party)
Apache License 2.0
54 stars 17 forks source link

Hide Network Error #13

Open ItzNotABug opened 7 years ago

ItzNotABug commented 7 years ago

Currently the Library shows a Dialog Pop-Up when there is No Internet Connection but instead there should be No Pop-Up at all if there is no Network Connection...

Most of the User's won't even bother to Refresh, so this can be a good feature where the App will only show Pop-Up ads when there is network available...

A method like - showErrorDialog(false); would be Good :)

hummatli commented 7 years ago

Hi. Library caches list at first time and shows it wether there is internet connection or not.

If there is not cached data it shows refresh button. Therefore I thing there is not any need for additional error dialog. :)

ItzNotABug commented 7 years ago

Seems like you misunderstood :P I didn't say to add an Additional error Dialog, I meant that if there is no Cache data or No Network then the Popup with the Refresh button should not show... Instead it should try to Load it the next time there is a network... Or try in Background (Async Task) :)

hummatli commented 7 years ago

Hmm. Interesting. I will thing about it.

Thanks for your idea. 👍

ItzNotABug commented 7 years ago

You're Welcome :) Do Update it Regularly :P