hummingbird-jp / stat-web

1 stars 0 forks source link

Shorten URL and Creating/Joining method changed drastically #195

Closed ryutarosuda closed 2 years ago

ryutarosuda commented 2 years ago

close #155

Important!

This PR contains breaking changes.

  1. URL to join channel will be based on channel name.
  2. Tokens are created at each client.
  3. Firestore structure changed.

Cloud Function not implemented yet!

How to use

  1. New Meeting >> Create a random channel name and join.
  2. Join Meeting >> Join a meeting with a valid channel name.
  3. Create Your Room >> Create a channel with a specific domain. You can choose your own!

Other

If you access https://stat-web-6372a.web.app/?channel=xxxxxxx, you will directly and automatically joins the channel.

image

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 505c824):

https://stat-web-6372a--pr195-shorten-url-v8957oeb.web.app

(expires Wed, 29 Sep 2021 13:06:44 GMT)

๐Ÿ”ฅ via Firebase Hosting GitHub Action ๐ŸŒŽ

yhakamay commented 2 years ago

@RQ2L84Q-ROW ใ‚ใ‚ŠใŒใจใƒผ๏ผใพใ ใ—ใฃใ‹ใ‚Š่ฆ‹ใ‚Œใฆ็„กใ„ใ‘ใฉใ€ๆœ€้ซ˜ๆ„Ÿไผใ‚ใฃใฆใใ‚‹ ๐Ÿค— 18ๆ™‚ใ‹ใ‚‰ๆœ€ๅคง30ๅˆ†ใ€ใƒฌใƒ“ใƒฅใƒผใฎๆ™‚้–“ใ‚‚ใ‚‰ใ†ใ“ใจใงใใ‚‹๏ผŸใŠใ‚Œใ‚‚ๅพŒใ‚ใฎไบˆๅฎšใ‚ใ‚‹ใ‹ใ‚‰ๅปถใณใชใ„๏ผ

ryutarosuda commented 2 years ago

@yhakamay ็ขบ่ชใ‚ใ‚ŠใŒใจใ†๏ผใŸใ ใ”ใ‚ใ‚“ใ€ใƒใ‚คใƒˆๅ…ˆใซ็งปๅ‹•ไธญใงใ„ใพใฏ้›ฃใ—ใ„๏ผ

yhakamay commented 2 years ago

@RQ2L84Q-ROW

Cloud Function not implemented yet!

ใ“ใ‚Œใฃใฆไฝ•ใ‚’ๆ„ๅ‘ณใ—ใฆใ‚‹๏ผŸใƒ‘ใƒƒใจใฟใŸๆ„Ÿใ˜ generateTokenWithUid() ใฏไฝฟใ‚ใ‚Œใฆใ‚‹ใฃใฝใ‹ใฃใŸใฎใง๏ผ

ryutarosuda commented 2 years ago

@yhakamay ่ชฌๆ˜Ž่ถณใ‚Šใชใใฆใ”ใ‚ใ‚“็ฌ‘ setLimitTime ใฎ่จญๅฎšใ‚’ๆ‹…ๅฝ“ใ—ใฆใ‚‹Cloud Functionsใ‚’ใพใ ใ‚ขใƒƒใƒ—ใƒ‡ใƒผใƒˆใ—ใฆใชใ„ใฃใฆๆ„ๅ‘ณ๏ผ

yhakamay commented 2 years ago

@RQ2L84Q-ROW ใŠใ‘ใ€็†่งฃใ—ใŸ๏ผmergeใ—ใฆ่‰ฏใใชใฃใŸใ‚‰ๆ•™ใˆใฆ๏ผ่ปฝใใƒฌใƒ“ใƒฅใƒผใ—ใŸๆ„Ÿใ˜ๅ•้กŒใชใ•ใใ†

ryutarosuda commented 2 years ago

@yhakamay ใŠ้ก˜ใ„ใ—ใพใƒผใ™๏ผ

yhakamay commented 2 years ago

@RQ2L84Q-ROW ๆœ€้ซ˜๏ผใ‚ใ‚ŠใŒใจใ†๐Ÿ˜Š