search

hummingbird-jp / stat-web

1 stars 0 forks source link

Fix 199: Agora tracks and Firestore timings #202

Closed ryutarosuda closed 3 years ago

ryutarosuda commented 3 years ago

Fix #199

Agora Track invisible -> visible

I added await at client.subscribe

Firestore timing fix

It seems just adding await before stat_firebase.init() in agora.js did not fix the issue. Instead, I modified try{}...catch{}...finally{} structure at stat_firebase.js which resolved the issue.

One more thing...

I created custom logging function. Use this for loggings that are not for debugging.

export function statConsoleLog(msg) {
    console.log(`%cStat! [DEBUG]: %c${msg}`, 'color: #8f35ff', 'color: #0D0D0D');
}
Screen Shot 2021-09-23 at 10 50 16 Screen Shot 2021-09-23 at 10 38 26
github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit 99b5e00):

https://stat-web-6372a--pr202-fix-199-hpwa9w3s.web.app

(expires Thu, 30 Sep 2021 02:15:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

ryutarosuda commented 3 years ago

Well it seems not working... It was working at localhost I will check again.

ryutarosuda commented 3 years ago

@yhakamay It is working indeed.

  1. Chrome window
  2. Chrome private window

Did you join from the same browser? Due to the permission configuration

await auth.setPersistence(authInstance, auth.browserLocalPersistence);

joining from the same browser might cause some problem.

Screen Shot 2021-09-23 at 11 33 39
ryutarosuda commented 3 years ago

Please share your console log as well!

yhakamay commented 3 years ago

@RQ2L84Q-ROW Thanks for the suggestion. I've tried to join with two Google accounts, one on normal mode, another on incognito mode. And it now works! image