fix titles for english preference

hummingbird-me / kitsu-tools

:hammer: The tools we use to build Kitsu, the coolest platform for anime and manga

https://kitsu.app

Apache License 2.0

2.09k stars 265 forks source link

fix titles for english preference #636

Closed trmcnvn closed 9 years ago

trmcnvn commented 9 years ago

REF: #623

Anything else needed? We should get this pushed ASAP /cc @DNA

trmcnvn commented 9 years ago

Also fixed what seems to be a bug reported here: https://forums.hummingbird.me/t/canonical-titles-only-showing-as-romanized/26846

Our title code is pretty bad, I think @NuckChorris was working on a change for it :(.

NuckChorris commented 9 years ago

I was hoping to refactor it into a separate table but thats more of a long term endeavor and between my feed refactor and oauth2 I've already got enough patches to stage.

For now I think renaming them english_title and romaji_title would help greatly.

DNA commented 9 years ago

This should resolve all the present bugs until do a better refactor :)

DNA commented 9 years ago

Maybe add some tests to check if we are not presenting empty string as valid ones? It'll help in the next refactor too