search

hummingbird-me / kitsu-tools

:hammer: The tools we use to build Kitsu, the coolest platform for anime and manga
https://kitsu.app
Apache License 2.0
2.09k stars 264 forks source link

Quick update - canGoForward #683

Closed danreeves closed 8 years ago

danreeves commented 9 years ago

There's a bug with the canGoForward check in the quick update component, here: https://github.com/hummingbird-me/hummingbird/blob/f031863451e34889a7b6e942ee7ca985ddacb90c/frontend/app/components/quick-update.js#L10

If your library_entries is a multiple of 6, so that the last page has 6 items, you can page to an empty set of entries.

screen shot 2015-10-11 at 20 59 43

JoshFabian commented 9 years ago

Thanks Dan, we'll be fixing this in the rewrite branch: https://github.com/hummingbird-me/hummingbird/tree/the-future

In the event that you'd like to help contribute when you have time here and there, I'd be happy to invite you to join our slack dev chat!

danreeves commented 9 years ago

Sorry, I missed that branch. Yeah, I'd love to join the slack: danr@fffunction.co

NuckChorris commented 8 years ago

Closing this as a V2 issue. Should be fixed in V3, though it may just not be a thing in V3 due to how the QU is in that.