search

hummingbird-me / kitsu-tools

:hammer: The tools we use to build Kitsu, the coolest platform for anime and manga
https://kitsu.io
Apache License 2.0
2.09k stars 264 forks source link

Split dockerfiles #721

Closed NuckChorris closed 8 years ago

NuckChorris commented 8 years ago

I think this is ready for daylight.

A few caveats:

  1. ember-cli uses notify to monitor, which doesn't trigger on VirtualBox Shared Folders, meaning your changes may not be automatically picked up unless you force it into polling mode.
  2. I'm not 100% certain the postgres/redis images use data volumes, so the persistence may screw up

But some awesomeness:

  1. You can bootstrap a development environment in one command: scripts/bootstrap
  2. All the versions are Modern™ — Node 5.9 and Ruby 2.3, which are each respectively the latest versions.
  3. docker-compose is just absolutely fucking fabulous
MiLk commented 8 years ago

I'm not 100% certain the postgres/redis images use data volumes, so the persistence may screw up

Data volumes are not removed by default: https://docs.docker.com/compose/reference/rm/

NuckChorris commented 8 years ago

Data volumes are not removed by default

I know, but I'm not sure they're using data volumes at all

trmcnvn commented 8 years ago

:+1: Only one thing, can you also remove the test for the get-api-host util?

NuckChorris commented 8 years ago

Aha, I knew I'd miss something!