search

hummingbird-me / kitsu-tools

:hammer: The tools we use to build Kitsu, the coolest platform for anime and manga
https://kitsu.io
Apache License 2.0
2.09k stars 264 forks source link

Rename 'en_jp' to 'ja_en' #729

Closed trmcnvn closed 8 years ago

trmcnvn commented 8 years ago

Related Issue #708.

NuckChorris commented 8 years ago

Shit, I have this all backwards. The proper is actually en_JP, following the format ll_CC

https://www.w3.org/International/questions/qa-choosing-language-tags

trmcnvn commented 8 years ago

Okay will try get around to this tonight!

On Sun, 26 Jun 2016, 1:57 PM Peter Lejeck notifications@github.com wrote:

Shit, I have this all backwards. The proper is actually en_JP, following the format ll_CC

https://www.w3.org/International/questions/qa-choosing-language-tags

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hummingbird-me/hummingbird/pull/729#issuecomment-228583021, or mute the thread https://github.com/notifications/unsubscribe/AACPJrMBkCP8kug5lTC4TAq1e54hWBV5ks5qPfiwgaJpZM4Ip6Pt .

NuckChorris commented 8 years ago

Could you add episodes to the list? franchises already has the proper en_jp, so episodes should be the only remaining table which uses ja_en

trmcnvn commented 8 years ago

Sure, missed that one

NuckChorris commented 8 years ago

Awesome, other than that lgtm

trmcnvn commented 8 years ago

@NuckChorris Can you take a quick look over this again? Few more changes to keys throughout the app.

NuckChorris commented 8 years ago

Looks solid to me :tada: