search

hummingbird-me / kitsu-tools

:hammer: The tools we use to build Kitsu, the coolest platform for anime and manga
https://kitsu.app
Apache License 2.0
2.09k stars 265 forks source link

Show validation error messages on edits #731

Closed trmcnvn closed 8 years ago

trmcnvn commented 8 years ago

Currently a pending version is created even if there is validation errors. This hopefully puts an end to that.

A matter was brought up by @synthtech that Twitter image links have an odd file ending :orig/:large. This causes Paperclip to throw a validation error due to their content type spoof system. Seems we can support them by adding the content type mappings manually but unsure if its worth it due to V3 development.

/cc @NuckChorris

NuckChorris commented 8 years ago

In V3 I'm hoping to completely obliterate the original-filename portion and preferably do something like https://static.hummingbird.me/anime/1000/poster/large.png or maybe even explicitly name the styles after sizes like https://static.hummingbird.me/anime/1000/poster/100h.png

It's just so much cleaner of a URL going forward, but I have to write a migration script.

Other than that, LGTM

trmcnvn commented 8 years ago

:+1: sounds good.

On Sun, Jun 12, 2016 at 5:25 AM Peter Lejeck notifications@github.com wrote:

In V3 I'm hoping to completely obliterate the original-filename portion and preferably do something like https://static.hummingbird.me/anime/1000/poster/large.png or maybe even explicitly name the styles after sizes like https://static.hummingbird.me/anime/1000/poster/100h.png

It's just so much cleaner of a URL going forward, but I have to write a migration script.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hummingbird-me/hummingbird/pull/731#issuecomment-225388861, or mute the thread https://github.com/notifications/unsubscribe/AACPJhLDEnjD_NFDCtyEKF57pS2uzRhoks5qKwutgaJpZM4Iw5Io .