search

hummingbird-me / kitsu-tools

:hammer: The tools we use to build Kitsu, the coolest platform for anime and manga
https://kitsu.app
Apache License 2.0
2.09k stars 264 forks source link

Facebook Fixes #732

Closed trmcnvn closed 8 years ago

trmcnvn commented 8 years ago

Just some fixes for Facebook based accounts that have been brought to my attention.

NuckChorris commented 8 years ago

Out of curiosity why does the #save call break the facebook confirmation emails?

trmcnvn commented 8 years ago

Doesn't really break it, it just causes confusion IMO.

save causes the confirmation email to be sent, then right after #confirm!

deletes the token and confirms the account. Users still receive the email but with a link that won't work.

On Sun, Jun 12, 2016 at 5:28 AM Peter Lejeck notifications@github.com wrote:

Out of curiosity why does the #save call break the facebook confirmation emails?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hummingbird-me/hummingbird/pull/732#issuecomment-225389012, or mute the thread https://github.com/notifications/unsubscribe/AACPJulP9INkbKw_pLHjUKT_VoImt9F-ks5qKwxCgaJpZM4Izix0 .

NuckChorris commented 8 years ago

Ah, that makes sense. LGTM :+1: