hummingbird-me / kitsu-tools

:hammer: The tools we use to build Kitsu, the coolest platform for anime and manga

https://kitsu.io

Apache License 2.0

2.09k stars 264 forks source link

MyAnimeList DataImporter #739

Closed trmcnvn closed 8 years ago

trmcnvn commented 8 years ago

Noticed some issues when using this tonight.

Missing case for PG-13 for age_rating - results in nil
Method subtype should be show_type until a rename actually happens

/cc @NuckChorris @toyhammered

toyhammered commented 8 years ago

will fix the first issue for PG-13. (Good call just looked at code and noticed we were only getting PG and PG13)

As for the second one there was a conflict with show_type and manga_type. # TODO: removed subtype (show_type, manga_type issue), so hopefully Nuck will fix that soon.

toyhammered commented 8 years ago

743

NuckChorris commented 8 years ago

@toyhammered in future, you can use (fixes #743) in a commit message to have the issue automatically close when the PR gets merged :thumbsup: