hummingbird-me / kitsu-tools

:hammer: The tools we use to build Kitsu, the coolest platform for anime and manga
https://kitsu.app
Apache License 2.0
2.09k stars 264 forks source link

User blocking model #747

Closed NuckChorris closed 7 years ago

NuckChorris commented 8 years ago

Right now, user blocking doesn't need to actually be applied (feeds don't exist yet!)

But we can build the model. Hell, it... might just be a two-column table.

pixeldesu commented 8 years ago

I don't know how the relationship system works on HB right now, but why not use a kind of 3 way "Relationship" model here, based on types?

3 way, as in:

Kind-of example of what I'm talking about available here: https://github.com/stellate/stellate/blob/master/app/models/user.rb (note: it can be done better than here, but just to get the general idea of it)

NuckChorris commented 8 years ago

Following and blocking are two very different things such just happen to have the same two columns. Why merge them when they're easily modeled separately? It just complicates the code to shove them in the same table

DNA commented 8 years ago

Isn't it the same as #655?

NuckChorris commented 8 years ago

That's a meta-issue, this is specific to the server-side implementation of it