hummingbird-me / kitsu-tools

:hammer: The tools we use to build Kitsu, the coolest platform for anime and manga
https://kitsu.io
Apache License 2.0
2.09k stars 264 forks source link

Force rspec to run on test environment #750

Closed DNA closed 7 years ago

DNA commented 7 years ago

As we talked yesterday on Slack, we need to enforce Rspec to run on the test development :)

trmcnvn commented 7 years ago

I think this will still happen under bin/guard since it executes server/bin/rspec under development env.

NuckChorris commented 7 years ago

Yeah this should probably also happen to bin/guard

DNA commented 7 years ago

I've tested both and they are working fine now. And since we can just pass bin/rake RAILS_ENV=test task when needed, I don't think we need to change other scripts :)

NuckChorris commented 7 years ago

LGTM!

DNA commented 7 years ago

Can I haz merge? :P