search

hummingbird-me / kitsu-tools

:hammer: The tools we use to build Kitsu, the coolest platform for anime and manga
https://kitsu.io
Apache License 2.0
2.09k stars 265 forks source link

Library switches view when updating episode count #778

Closed chrislegault closed 7 years ago

chrislegault commented 7 years ago

Thank you for taking the time to open an issue!

For bug reports please include the following section in your issue details.

Description: Assuming something isn't properly tracking the AJAX calls going out for the library and it ends up thinking the tab I'm on isn't actually the one I'm on 😄

Steps to reproduce: Open up my library, switch to a tab that takes long to load (for me Completed). Before that finishes loading, switch to Currently Watching. Increment an episode count for a show. Count will update but the view will switch to the previous tabs content (Completed).

Screenshots (if applicable): bug

OS and Browser: Mac Sierra - Chrome 55.0.2883.95

trmcnvn commented 7 years ago

Thanks for the report @astraldragon! I'm going to look into this today.

chrislegault commented 7 years ago

With the re-brand seems like the project is still open source? May take a look at learning some Ember 😄 Looks like you are almost a one man team for the UI? I'm always good for filling in unit tests if you wanted contributions.

cybrox commented 7 years ago

@astraldragon Yeah, staying open source was a very important goal for us, even after the rebrand. Currently, it's mostly @vevix, @JoshFabian and me working on client side. Especially testing needs lots of love after rushing through a lot of things during release, so any contribution is welcome 😄

trmcnvn commented 7 years ago

Tests are always welcome 😸!

JoshFabian commented 7 years ago

@astraldragon shoot me an email if you'd like to join our dev slack! josh@kitsu.io

chrislegault commented 7 years ago

Yeah for sure. I'll ping you.