search

hummingbird-project / hummingbird-lambda

Hummingbird running inside an AWS Lambda
Apache License 2.0
24 stars 3 forks source link

Support launching a HBMixedLambdaApplication as either HTTP or Lambda #21

Closed Joannis closed 3 months ago

Joannis commented 7 months ago

This PR allows users to conform to HBMixedLambdaApplication (both HBApplicationProtocol and HBLambda). This allows running in either mode, through a getter. The example implementation toggles based on a value in the HBEnvironment.

Naming is very much open for discussion, I'm far from happy with this name

codecov[bot] commented 7 months ago

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (c7dc7a8) 89.95% compared to head (0e60d57) 77.04%.

Files Patch % Lines
...ces/HummingbirdLambda/MixedLambdaApplication.swift 0.00% 36 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.x.x #21 +/- ## =========================================== - Coverage 89.95% 77.04% -12.91% =========================================== Files 8 9 +1 Lines 209 244 +35 =========================================== Hits 188 188 - Misses 21 56 +35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adam-fowler commented 3 months ago

Can we close this now, anyway with the Source associatedtype this won't be possible anymore