search

hummingbird-project / hummingbird-lambda

Hummingbird running inside an AWS Lambda
Apache License 2.0
24 stars 3 forks source link

2.x.x: Fix multi-value query values and headers for APIGatewayV2 #24

Closed adam-fowler closed 6 months ago

adam-fowler commented 7 months ago

Added new protocol requirements for APIRequest which return the query string and http headers in a generic form. Implement both of these for APIGatewayRequest and APIGatewayV2Request

There are no tests in this PR as the tests are in the XCTest PR #25 and adding any here will just produce merge issues

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 83.72093% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 85.45%. Comparing base (a36500e) to head (593a3cc).

Files Patch % Lines
Sources/HummingbirdLambda/APIGatewayLambda.swift 76.66% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.x.x #24 +/- ## ========================================== - Coverage 89.95% 85.45% -4.50% ========================================== Files 8 8 Lines 209 220 +11 ========================================== Hits 188 188 - Misses 21 32 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.