search

hummingbird-project / hummingbird-lambda

Hummingbird running inside an AWS Lambda
Apache License 2.0
24 stars 3 forks source link

compilation broken on 2.0.0-beta.5 due to missing manifest dependency #31

Closed tayloraswift closed 3 months ago

tayloraswift commented 3 months ago

we are failing to build docs for 2.0.0-beta.5 on Swiftinit due to the following error:

/home/ubuntu/unidoc/checkouts/hummingbird-lambda/.build.ssgc/checkouts/hummingbird/Sources/HummingbirdCore/Request/RequestBody.swift:15:8: error: no such module 'Collections'
import Collections
       ^

compiling locally with --explicit-target-dependency-import-check=error reveals the problem:

error: Target HummingbirdCore imports another target (Collections) in the package without declaring it a dependency.
adam-fowler commented 3 months ago

I never saw this issue on my macOS, Linux CI was not complaining then as soon as you post this issue the examples CI failed. I cannot replicate this locally but anyway it obviously an issue so added dependency and did a new release of Hummingbird