search

hummingbird-project / hummingbird-lambda

Hummingbird running inside an AWS Lambda
Apache License 2.0
24 stars 3 forks source link

Support HB 2.x.x #8

Closed Joannis closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (39479b7) 85.41% compared to head (43bc7fd) 90.43%. Report is 1 commits behind head on main.

:exclamation: Current head 43bc7fd differs from pull request most recent head b18219d. Consider uploading reports for the commit b18219d to get more accurate results

Files Patch % Lines
Sources/HummingbirdLambda/LambdaHandler.swift 84.37% 5 Missing :warning:
Sources/HummingbirdLambda/ErrorMiddleware.swift 75.00% 1 Missing :warning:
Sources/HummingbirdLambda/Lambda.swift 90.00% 1 Missing :warning:
...ources/HummingbirdLambda/Response+APIGateway.swift 93.75% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8 +/- ## ========================================== + Coverage 85.41% 90.43% +5.01% ========================================== Files 7 8 +1 Lines 192 209 +17 ========================================== + Hits 164 189 +25 + Misses 28 20 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adam-fowler commented 10 months ago

Regarding how this PR is structured. Can we rename the branch and have it merge into a 2.x.x branch which is a copy of the main branch.