search

hummingbird-project / hummingbird

Lightweight, flexible HTTP server framework written in Swift
Apache License 2.0
1.16k stars 53 forks source link

Add test dependency to fix linking error in unit tests #504

Closed JonPulfer closed 3 months ago

JonPulfer commented 3 months ago

I was getting a linking error when trying to run the unit tests. Adding this dependency to HummingbirdRouter fixed that error.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.01%. Comparing base (e78cde7) to head (368320f). Report is 94 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #504 +/- ## ========================================== - Coverage 84.86% 83.01% -1.86% ========================================== Files 98 94 -4 Lines 5320 4280 -1040 ========================================== - Hits 4515 3553 -962 + Misses 805 727 -78 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JonPulfer commented 3 months ago

For some reason, swiftformat in Xcode creates a suspiciously large changes to the formatting of the white space in the file. Running swiftformat on the CLI just updates the whitespace on the line I changed. I have swiftformat v0.53.8 installed.

adam-fowler commented 3 months ago

thank you for this