hummingbot / deploy

This repository provides various examples of how to deploy Hummingbot using Docker.
Apache License 2.0
86 stars 90 forks source link

Deploy - Creates instance using different docker image #44

Closed rapcmia closed 5 months ago

rapcmia commented 5 months ago

When testing PR18 then launch the bot with controller but without selected available image it uses dardonacci/hummingbot:latest instead of hummingbot/hummingbot:latest

image image

Recording here: https://www.loom.com/share/4bdd19ce15724943845641386d7d5134

Steps to reproduce:

  1. Setup deploy on source ( dashboard + backend-api + hummingbot-broker )
  2. On dashboard page, create config then deploy without selecting any images
  3. Go to terminal and run docker ps or docker images to check the container and image used
cardosofede commented 5 months ago

good catch @rapcmia here is the fix: https://github.com/hummingbot/dashboard/pull/152 @david-hummingbot build the new dashboard image from this PR if works

rapcmia commented 5 months ago

Fix merged to master branch https://github.com/hummingbot/dashboard/pull/152