search

humpalum / vscode-sigma

MIT License
16 stars 8 forks source link

Update YAML.tmLanguage.json #13

Closed huyusukesan closed 11 months ago

huyusukesan commented 1 year ago

modif syntaxe for tag "tlp" to be ok with the rfc SIGMA (https://sigmahq.github.io/sigma-specification/Tags_specification.html#namespace-tlp)

humpalum commented 1 year ago

Hey thanks for your contribution!

Could you give a quick rundown what exactly this change is doing? Maybe you can give an example of what you are aiming to fix?

Thank you!

huyusukesan commented 1 year ago

hi,with this contribution, i would to fix the fact that the tag "tlp" isn't interpret correctly.i think that my correction isn't totaly good but they correct my rule file. when i insert this tag, the extension mark it to "bad tag" and no fix but in sigma specifications this tag can be added in this format:tlp.amber, tlp.green .... (lower case) thank's for your return.

Le mardi 26 septembre 2023 à 15:20:06 UTC+2, Tobias Michalski ***@***.***> a écrit :

Hey thanks for your contribution!

Could you give a quick rundown what exactly this change is doing? Maybe you can give an example of what you are aiming to fix?

Thank you!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

humpalum commented 11 months ago

As far as i can see, this change just breaks the tag highlighting completely. We need to add the tlp tags somewhere else.

humpalum commented 11 months ago

fixed in #5071ad11f52460bc32236e2d8f0668227dc8f359 Please open a new issue if you still think that there is an issue with this