search

hundehausen / monero-suite

Build your personal docker-compose.yml file for Monero services.
https://monerosuite.org
23 stars 5 forks source link

Wrong port in container-ports and ufw #10

Closed Max-F-Helm closed 2 months ago

Max-F-Helm commented 2 months ago

Hi,\ I noticed a potential mistake in the provided configurations:

The monerod command in the container is started with --rpc-bind-port=18081 but both the ports section and ufw commands use port 18080.

hundehausen commented 2 months ago

Hi @Max-F-Helm,

--rpc-bind-port=18081 should not be exposed via the internet or even in your LAN. For this we have --rpc-restricted-bind-port=18089, which is present int the ports section as in the ufw commands section.

But we could expose port 18081 onto the local machine with

ports:
    - 18080:18080 # p2p port
    - 127.0.0.1:18081:18081 # unrestricted rpc port
    - 18089:18089 # restricted rpc port
Max-F-Helm commented 2 months ago

Yes, sorry, I mixed up the meaning ports.\ Closing this.