hundeva / Lean-Launcher

Pixel Launcher with a few added useful options
Other
507 stars 85 forks source link

Icons don't show up when I try to override an app icon #202

Open ghost opened 6 years ago

ghost commented 6 years ago

Take a random icon pack, search for a word, this is how many icons show up in the launcher:

screenshot_20180521-104910

In the icon pack itself, there are clearly more than 3 icons for WhatsApp:

screenshot_20180521-104939

hundeva commented 6 years ago

Which version of the launcher are you using?

ghost commented 6 years ago

@hundeva The latest one from the play store, 1.1.3

It happens with every icon pack

bedlia commented 6 years ago

Also aren't visible dots and other symbol icons in icon packs.

Muscarv2 commented 6 years ago

I can confirm this issue. Icons that have multiple versions only show one. For example: I'm using Borealis icon pack, and the camera has about 10 different color variations but lean launcher only shows one of them. Same for every app and icon pack.

hundeva commented 6 years ago

I would be happy if you guys could provide a few examples, with free icon packs, with the following infos, screenshots are not needed.

Play Store link of the icon pack: _ Search term: Expected number of icons showing up: Actual number of icons showing up:

A few example would be awesome, since I'm sure there are tags that I do not parse currently, that would be usable for searching purposes. Different packs may use different terms, that is why the more example the better.

Alternatively, if you know example xml's which describe more complex packs, that would help immensely as well.

ghost commented 6 years ago

@hundeva, hey I did a few of these, hope it's helpful.

Another thing you could do is allow us to pick an icon from the icon pack directly, like Nova does, so you wouldn't have to worry about icons not showing up. Anyway, here are my results:

Play Store link of the icon pack: https://play.google.com/store/apps/details?id=com.themezilla.pixelui

Search term: youtube Expected number of icons showing up: 10 Actual number of icons showing up: 10

Search term: firefox Expected number of icons showing up: 4 Actual number of icons showing up: 2

Search term: facebook Expected number of icons showing up: 16 Actual number of icons showing up: 20 (interesting)

Search term: chrome Expected number of icons showing up: 10 Actual number of icons showing up: 9

Search term: instagram Expected number of icons showing up: 6 Actual number of icons showing up: 7

Search term: settings Expected number of icons showing up: 13 Actual number of icons showing up: 8

Search term: spotify Expected number of icons showing up: 1 Actual number of icons showing up: 2 (some app that sets spotify as your alarm shows up)

Search term: clock Expected number of icons showing up: 19 Actual number of icons showing up: 20

Search term: camera Expected number of icons showing up: 43 Actual number of icons showing up: 36

bedlia commented 6 years ago

I'm with @khaledson, choosing from the whole pack would be easier for us, but I don't know if it would be easier for you to implement. (This way even dots, folders icon and symbols in the Icon Pack could be chosen if someone likes them)

Play Store link of the icon pack: https://play.google.com/store/apps/details?id=com.zavukodlak.candycons&hl=en

Search term: WhatsApp Expected number of icons showing up: 22 Actual number of icons showing up: 1

Search term: Facebook Expected number of icons showing up: 13 Actual number of icons showing up: 3 (and one is Facebook Messenger, which isn't a result from the Icon Pack search)

Search term: Twitter Expected number of icons showing up: 2 Actual number of icons showing up: 2 (but one is Talon for Twitter, which isn't a result from the Icon Pack search)

Search term: Phone Expected number of icons showing up: 13 Actual number of icons showing up: 7 (but 5 of them are not results from the Icon Pack search)

Search term: Camera Expected number of icons showing up: 33 Actual number of icons showing up: 13

hundeva commented 6 years ago

Thanks, that should be enough! Looks like I got my homework for the weekend (next to the LG issue...).

uudruid74 commented 6 years ago

This is a big issue for me since an update to an icon pack (https://play.google.com/store/apps/details?id=com.marcotls.icons.h2o.free) caused some of my icons to show up as the "alt" versions and while I can see the one's I want in the pack, I can't force them. 😃 I think it doesn't like long names, or maybe it's spaces in the name?

ghost commented 6 years ago

@hundeva, what's the status on this one?

hundeva commented 6 years ago

Currently no update, but it is still planned.