search

hundredrabbits / Donsol

Card game for the Famicom, written in 6502 assembly
http://donsol.100r.co
MIT License
114 stars 17 forks source link

Window scaling #15

Closed Dinjoralo closed 6 years ago

Dinjoralo commented 6 years ago

Added various CSS adjustments and one JavaScript function to enable the play area to scale with the size of the window. Currently, scaling is only handled via window width to maintain aspect ratio.

neauoire commented 6 years ago

Okay, so I've reviewed the suggestion and I don't think I should merge it. It gets part of the job done, but really this should be done entirely in JS, not appending a block of CSS to the body.

I will try and implement this directly into the on_resize() method instead. Thanks for the suggested change, I see that you're learning programming, if you like, I can explain the changes made when I'm done porting. I'd be happy to help :)

Dinjoralo commented 6 years ago

I would be interested in seeing it, thanks! I'm in my last year of college for computer sciences. I haven't done much with JavaScript or web development, I'm more comfortable with C++. I oughta get web dev under my belt, maybe try making something in Electron in my spare time.