search

hundredrabbits / Noodle

Small, Sharp Sketch Tool
https://hundredrabbits.github.io/Noodle
MIT License
171 stars 23 forks source link

Noodle on iPad? #2

Open rpherman opened 5 years ago

rpherman commented 5 years ago

Noodle is great! Is there a way to bring support for the Apple Pencil for iPad Pros, or am I missing a trick? Thanks!

neauoire commented 5 years ago

I don't know what these are, is it like a mouse?

rpherman commented 5 years ago

An Apple iPad Pro as pictured here the digital Pencil. I can draw with Noodle on my PC and mouse, but I wanted to use my iPad Pro with the digital pencil, since I can control it better than a mouse.

neauoire commented 5 years ago

What happens when you draw on Noodle?

ghostlevel commented 5 years ago

Just tested out of curiosity (iPad Mini 5/Apple Pencil, Safari & Firefox), nothing happens. Same thing when touching the canvas/page.

When used on general web pages (or iOS apps not specifically tailored for the Pencil) it seems to me the Apple Pencil acts the same way as any (one-finger) touch.

But i know nothing about JS and mobile dev so i have no idea if it would require to manage specific touch events for mobile. Or manage the mouse events in another way...

// Aside: I would guess it would end up out of scope for this tool / or be a different thing. Stating the obvious but any mobile/iPad user would also need to use the app with a BT keyboard (although iPad Pro's and others have keyboard covers, it's not the most common use-case for mobile devices). Perhaps someone could make a mobile-friendly fork of Noodle and add something like a tiny strip-like mobile UI to replace the keyboard events/shortcuts...

ghost commented 5 years ago

there is a mobile mode in devtools of chrome and firefox (higlighted): devtools-mobile

i was currently tinkering with it, but some code decided to loop forever..

gonna resume at some later time; will make a PR when it's ready

0xdstn commented 5 years ago

Oh I didin't notice this issue before I created my PR for adding touch support. It should fix this issue. I didn't test on an iPad specifically, but it worked on my Asus Zenbook touch screen and my Pixel 2 screen.

If you want, you can test on your iPad here, which has my fix - http://tilde.town/~dustin/Noodle/

neauoire commented 5 years ago

@rpherman let me know if that works for you

ghostlevel commented 5 years ago

@neauoire, @rpherman, Tested on latest Noodle for a while tonight (iPad Mini 5 with Pencil), works for me here. Touch & Apple Pencil work. Every mode and shorcut work too except for CTRL-DEL/BACKSPACE and 'S' but i suppose it is expected.