hungdev / react-native-instagram-login

a react native instagram login component (support android & ios). Pull requests are welcome!
https://www.npmjs.com/package/react-native-instagram-login
184 stars 103 forks source link

How is this component secure? The app secret is required in the component? #113

Closed princefishthrower closed 2 years ago

princefishthrower commented 2 years ago

Hi all,

I'm wondering how this component / login flow is secure, as it requires the app secret directly as a prop. Shouldn't the app secret be referenced and used only in a server-like environment?

Interested to hear anybody's thoughts on this.

Cheers,

Chris

princefishthrower commented 2 years ago

My bad, I now see the discussion: https://github.com/hungdev/react-native-instagram-login/issues/54 and the corresponding documentation in the README. However, this should be the default implementation. (app secret should not even be implemented as a prop)