hunger / downloader

Simple HTTP/HTTPS file downloader crate.
27 stars 10 forks source link

Allow user to provide their own digest algorithm, remove sha3 dependency #19

Closed dralley closed 2 years ago

dralley commented 2 years ago

Let user use whichever implementation of digest::Digest they like.

closes #20

dralley commented 2 years ago

Since the verify feature would no longer require a heavy dependency (digest::Digest is just a trait and the digest crate doesn't have many deps) maybe it would make sense to have verify be provided by default?

hunger commented 2 years ago

Could you do a quick cargo fmt? Or shall I?

I use pre-commit to make sure to not forget to clean up when committing:-)

dralley commented 2 years ago

It's an API break yes. Because the old verification function (downloader::verify::sha3_256) is gone

dralley commented 2 years ago

I ran cargo fmt

hunger commented 2 years ago

Thanks! Let's see what the Ci says now:-)