hungkhang / sipservlets

Automatically exported from code.google.com/p/sipservlets
0 stars 0 forks source link

createBranch for a new SIP Request #269

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.High possibility of simultaneous SIP requests creating the same branch 
parameter as it uses system.nanotime()

What is the expected output? What do you see instead?
The branch parameter is expected to be UNIQUE for each request.

What version of the product are you using? On what operating system?
MSS 2.0.0.FINAL

Please provide any additional information below.
I am using JBOSS 7 with Mobicents 2.0.0 for the application we are running. We 
have some sort of a heart beat (pinger) mechanism to check on the health of 
ICSCF from our application. To be more clear, there are 2 ICSCFs Primary and 
Secondary and we keep sending OPTIONS every configured seconds (10). The 
OPTIONS pings are sent successively to both Primary and Secondary and based on 
the failure we consider one of them as down and make sure the call is sent 
through the working ICSCF. It looks like the OPTIONS request created for 
Primary and Secondary has the same branch parameter since "System.nanoTime()" 
is what is being used while creating Branch for new requests. On searching 
about this, I do see a fix made in the link 
"https://code.google.com/p/mobicents/issues/detail?id=2278" using 
"ApplicationRoutingHeaderComposer.randomString()". I am assuming that is a 
correct fix but just not sure why it wasn't merged on future versions. Please 
comment and let me know if otherwise.

Original issue reported on code.google.com by Prakoo...@gmail.com on 2 May 2014 at 7:36

GoogleCodeExporter commented 9 years ago

Original comment by jean.deruelle on 2 May 2014 at 8:09

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 25e5d7f78e16.

Original comment by jean.der...@telestax.com on 2 May 2014 at 9:03

GoogleCodeExporter commented 9 years ago

Original comment by jean.der...@telestax.com on 25 Aug 2014 at 10:52