hungpham2511 / toppra

robotic motion planning library
https://hungpham2511.github.io/toppra/index.html
MIT License
625 stars 170 forks source link

[cpp]A numerical improvement. Refine tests. #120

Closed hungpham2511 closed 4 years ago

hungpham2511 commented 4 years ago

Changes in this PRs:

Checklists:

In progress: I will update this PR to run the integration test on CI.

jmirabel commented 4 years ago

Add randomized tests to compare Python and C++ API

Thanks. I was unsure how to put this test in the Python unit test.

jmirabel commented 4 years ago

I see that CI runs on xenial. On xenial, robotpkg provides Python 3.5 stuff, but not Python 3.6. So CI should install robotpkg-py35-pinocchio instead.

jmirabel commented 4 years ago

The available versions of py??-pinocchio depending on the distribution can be found here: http://robotpkg.openrobots.org/rbulk/robotpkg/math/py-pinocchio/index.html

hungpham2511 commented 4 years ago

The available versions of py??-pinocchio depending on the distribution can be found here: http://robotpkg.openrobots.org/rbulk/robotpkg/math/py-pinocchio/index.html

Thanks. I am skipping the pinocchio tests for now, as on the base CI image is running 16.04 and there are only 2.7 and 3.5, which are incompatible with the python codebase.

hungpham2511 commented 4 years ago

Look like we will need to upgrade the CI image to bionic and test with 3.6 and 2.7.

jmirabel commented 4 years ago

Another option is to install Pinocchio from conda. I never tried myself. https://github.com/conda-forge/pinocchio-feedstock