Closed tykurtz closed 3 years ago
Friendly ping to @hungpham2511 for review.
Hey thanks for the PR and, pinging me. Have been kind of busy recently and sort lost track of this PR. I will have a look shortly :)
LGTM. Thanks!
Thank you so much! Could you publish a new release to pypi ?
I just kick-start the CI. A new version should be available soon.
Fixes an issue related to #151 .
To reproduce
and you should get
Changes in this PRs:
Checklists:
Some background on what exactly this change is can be found here, https://pypi.org/project/oldest-supported-numpy/
and https://github.com/scikit-learn-contrib/hdbscan/issues/457#issuecomment-773671043
The other way around this would be to require
numpy>=1.20
but that would rule out setups which require older versions ofnumpy
(notablytensorflow
)