Make path times public.

hungpham2511 / toppra

robotic motion planning library

https://hungpham2511.github.io/toppra/index.html

MIT License

603 stars 167 forks source link

Make path times public. #197

Closed jess-moss closed 2 years ago

jess-moss commented 2 years ago

Fixes #

Changes in this PRs:

Checklists:

[x] Update HISTORY.md with a single line describing this PR

This change is

jmirabel commented 2 years ago

Per Issue #187

Thanks for pointing the issue. It made me realize I overlooked the changes. The prototype should be const Vector getTimes() const so two additional changes:

const to help the compiler (although it should be able to understand it)
function name change to try to stick to the naming convention followed elsewhere in this lib (and Ts is a little obscure).

hungpham2511 commented 2 years ago

Hi @jess-moss, thanks for the PR! Could you also add a line to the changelog?

Thanks @jmirabel for the review. The PR looks good to me; I will be happy to merge once all comments are resolved.