hungpham2511 / toppra

robotic motion planning library
https://hungpham2511.github.io/toppra/index.html
MIT License
603 stars 167 forks source link

Add initial gridpoints to proposeGridpoints #227

Closed jmirabel closed 1 year ago

jmirabel commented 1 year ago

Changes in this PRs:

Checklists:

jmirabel commented 1 year ago

@hungpham2511 gentle reminder.

jmirabel commented 1 year ago

I updated the code based on the comments. @hungpham2511 could you have another look please ?

jmirabel commented 1 year ago

I don't understand why CI job Python package / cpp (3.6, ubuntu-18.04) (pull_request) gets cancelled...

hungpham2511 commented 1 year ago

I don't understand why CI job Python package / cpp (3.6, ubuntu-18.04) (pull_request) gets cancelled...

Indeed it's very strange. I am checking with develop branch.

hungpham2511 commented 1 year ago

CI passes after restarting.

jmirabel commented 1 year ago

Thanks.