search

hungps / flutter_pokedex

Pokedex app built with Flutter (with lots of animations) using Clean Architecture
https://hungps.com
Other
2.36k stars 562 forks source link

Add new AppIcons for iOS and Android #10

Closed LBeul closed 3 years ago

LBeul commented 4 years ago

Implement a fitting icon for both the iOS and Android Launcher instead of the generic Flutter Logo. The Icon was built by myself in Figma and consists of some usual geometric shapes, so no copyright issues with that.

ball

hungps commented 4 years ago

@LBeul Great, thanks! Could you please make a transparent background version for android? Cause it looks better if someone like to theming their OS (like using an icon pack with a custom icon background, rounded icon, etc).

And also don't include pubspec.lock (because your pull request only add icons, not changing the code) and generated files (such as .flutter-plugins-dependencies, ios/Flutter/flutter_export_environment.sh). I forget to ignore them in .gitignore, will add next time. Sorry!

I'm currently refactoring the code and it would be nice if this icon can be used as the refresh indicator and loading indicator icon. If you could add a transparent background version icon (pokeball-logo.png - 40x40) to the assets/images folder, it will be awesome.

Thanks again!

LBeul commented 4 years ago

Hey there.

In commit 26bb53a, I just swapped the Icons for new ones with transparent background and added both a png and svg to the assets as requested by @scitbiz :)

hungps commented 4 years ago

@LBeul Please rebase your code

LBeul commented 4 years ago

@scitbiz should work now

hungps commented 4 years ago

@LBeul You pull request still have conflicts, please rebase and squash into one commit only

hungps commented 3 years ago

I'll close this issue here because there is no action coming up and the master branch has changed. If you still want to add this, please open a new pull request based on the new master branch. Thank you!