search

hungps / flutter_pokedex

Pokedex app built with Flutter (with lots of animations) using Clean Architecture
https://hungps.com
Other
2.31k stars 562 forks source link

Pokemon image is not showed when the internet connection has been lost #35

Closed jsmartinezn closed 2 years ago

jsmartinezn commented 3 years ago

When i lost internet connection the pokemon images don't load

hungps commented 3 years ago

Hi @jsmartinezn, Currently, this app doesn't save the image because there are too many of them (about ~1000 images). I'm considering 2 possible solutions:

  1. Show the pokemon placeholder with an exclamation mark (!) indicate that the image cannot be load due to the internet connection.
  2. Add a new feature that will allow the user to download all the images and the pokemons into the device's storage so that the app can still be used in offline mode.

I think the latter will be better, what do you think?

jsmartinezn commented 3 years ago

Hi,

I prefered the first option because as the number of registered pokemon increases, it will not be feasible to store them all locally for memory space.

De: Pham Sy Hung @.> Enviado: martes, 1 de junio de 2021 10:57 p. m. Para: scitbiz/flutter_pokedex @.> Cc: Juan Sebastian Martinez Niño @.>; Mention @.> Asunto: Re: [scitbiz/flutter_pokedex] Pokemon image bug (#35)

Hi @jsmartineznhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjsmartinezn&data=04%7C01%7Cjs.martinezn%40uniandes.edu.co%7C979dd33833ae434a289908d9257a8cc7%7Cfabd047cff48492a8bbb8f98b9fb9cca%7C0%7C0%7C637582030543319176%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=xsm5ltBqEWrdDJYqRMJFGH%2Fr55iakm%2F7j4MbDTf3vzw%3D&reserved=0, Currently, this app doesn't save the image because there are too many of them (about ~1000 images). I'm considering 2 possible solutions:

  1. Show the pokemon placeholder with a question mark (!) indicate that the image cannot be load due to the internet connection.
  2. Add a new feature that will allow the user to download all the images and the pokemons into the device's storage so that the app can still be used in offline mode.

I think the latter will be better, what do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fscitbiz%2Fflutter_pokedex%2Fissues%2F35%23issuecomment-852698862&data=04%7C01%7Cjs.martinezn%40uniandes.edu.co%7C979dd33833ae434a289908d9257a8cc7%7Cfabd047cff48492a8bbb8f98b9fb9cca%7C0%7C0%7C637582030543329171%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2FI7efRO774OL%2BVCpj9YtdLutn2uECIM7DLw8M15sw2w%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKDDQZZL6HQG5FY7KIGPEZDTQWT2ZANCNFSM455X5MAQ&data=04%7C01%7Cjs.martinezn%40uniandes.edu.co%7C979dd33833ae434a289908d9257a8cc7%7Cfabd047cff48492a8bbb8f98b9fb9cca%7C0%7C0%7C637582030543339165%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=szjgK1QHuwmS7VQDcJvEG7QgkpZkOAOtsBktl9AREPo%3D&reserved=0.

hungps commented 3 years ago

@jsmartinezn Can you confirm https://github.com/scitbiz/flutter_pokedex/pull/39 solve your problem?