search

hungps / flutter_pokedex

Pokedex app built with Flutter (with lots of animations) using Clean Architecture
https://hungps.com
Other
2.36k stars 562 forks source link

Items List Feature #48

Closed LucasFab closed 2 years ago

LucasFab commented 2 years ago

Hello,

This Pull Request is based on the add of the Items List to the Pokedex.

I created the repository, providers, use_cases to manage the data. I had to create my own gist to manage the data of the items, if you want to create it yourself tell me and give me the URL and I will change the URL in the repository.

For the front-end part I chose to stay with something quite similar to the list of the pokemon in the pokedex, meaning that you have a list of the items with an image and the name of the item (and the category of it).

Unfortunately, some items on the json data had a correct URL but there was only one white pixel on this URL for the image so some items don't have an image.

Feel free to comment any suggestions to make it better !

hungps commented 2 years ago

Hi @LucasFab, thanks for your contribution! It would be nice if you could attach some screenshots or videos about your new screen.

hungps commented 2 years ago

@LucasFab Because the repository is in my account so that it's better that I'm the one who keeps all the related stuff about the project. I've copied your gist, so this is the URL. Thank you! https://gist.githubusercontent.com/scitbiz/69bb2082702ecbdf3d26cd7ba2a2e00d/raw/pokemon_items.json

LucasFab commented 2 years ago

Hi @LucasFab, thanks for your contribution! It would be nice if you could attach some screenshots or videos about your new screen.

I will add the screenshots

LucasFab commented 2 years ago

@LucasFab Because the repository is in my account so that it's better that I'm the one who keeps all the related stuff about the project. I've copied your gist, so this is the URL. Thank you! https://gist.githubusercontent.com/scitbiz/69bb2082702ecbdf3d26cd7ba2a2e00d/raw/pokemon_items.json

Ok I will make the modification, thanks for the answers

LucasFab commented 2 years ago

Simulator Screen Shot - iPhone 12 - 2021-11-26 at 17 41 51

Here is a screenshot of the items list

0x1026 commented 2 years ago

I've checked the pr with my Redmi Note 8 Pro and I've not noticed any problem ^^

image

LucasFab commented 2 years ago

I did the modification acording to the PR requirements comments

hungps commented 2 years ago

Hi @LucasFab, your PR has conflict, please take a look and resolve it

hungps commented 2 years ago

Finished in #58