[Urgent] Update the Pokemon source url

hungps / flutter_pokedex

Pokedex app built with Flutter (with lots of animations) using Clean Architecture

https://hungps.com

Other

2.31k stars 562 forks source link

[Urgent] Update the Pokemon source url #57

Closed 0x1026 closed 2 years ago

0x1026 commented 2 years ago

Actually, nothing is showing

hungps commented 2 years ago

Hi @Hugovidafe, this bug has been fixed in #52, I cannot reproduce the problem in the latest code. Could you please update the code in your local machine to the latest master and see if it is working or not? Thank you!

0x1026 commented 2 years ago

I just download https://codemagic.io/app/5d3727997dee22001bb7681c/build/61f974c029657a000ba19d82 from the last commit on master... Check the url on the files changed section.

hungps commented 2 years ago

@Hugovidafe Oh, the current url is working fine. But I spotted that the line <uses-permission android:name="android.permission.INTERNET"/> is gone in android/src/main/AndroidManifest.xml since I did the #53 one, that's the reason why it cannot fetch the data on the release build but still working in debug mode. Thank you so much for raising the problem, I haven't noticed that since then!

Because you've already opened this PR, could you please add the missing line to it? Thank you!

0x1026 commented 2 years ago

Ready! 🤗

hungps commented 2 years ago

Thank you!

0x1026 commented 2 years ago

No problem!

0x1026 commented 2 years ago

The first time I saw this warning when I tried to install this app after downloading it from CodeMagic

Screenshot_2022-03-01-06-07-35-116_com.android.vending.jpg

hungps commented 2 years ago

@Hugovidafe It's because the app is currently signed using the debug keystore only for demo purposes. Don't worry about it!