search

hungps / flutter_pokedex

Pokedex app built with Flutter (with lots of animations) using Clean Architecture
https://hungps.com
Other
2.31k stars 562 forks source link

works on chrome and macos #73

Closed Jesse-Lucas1996 closed 1 year ago

Jesse-Lucas1996 commented 1 year ago

Running on Windows 11: image image imo the icons are a bit too large on windows?

we are getting a pixel overflow

Running on Chrome: image image

Jesse-Lucas1996 commented 1 year ago

The https://assets.pokemon.com/ is returning a CORS issue but the app does run now. I also upgraded Flutter and all the packages

Also sorry for the super long PR

felipecastrosales commented 1 year ago

Uhhh, very good! 🚀 Probably resolved issue #37.

Jesse-Lucas1996 commented 1 year ago

@felipecastrosales I kept seeing these can I do it and no one did it, so I thought I just would

0x1026 commented 1 year ago

I'm updating my work environments so I'm gonna take a while to check this PR. At least, I debugged already with Chrome, the app needs some improvement for scrolling ^^

I saw some theme changes on the code. @hungps, can you check this PR? It's interesting!

felipecastrosales commented 1 year ago

@hugovidafe I haven't tried the code yet, but likely the theme changes come from Flutter 3.7.0. Or not?

0x1026 commented 1 year ago

@hugovidafe I haven't tried the code yet, but likely the theme changes come from Flutter 3.7.0. Or not?

Idk, I didn't follow the Flutter change logs. When I already have the updated environment, I will catch up with the news.

hungps commented 1 year ago

@Jesse-Lucas1996 Thank you so much for your contribution!

@hugovidafe LGTM! There are some minor things I would like to change, but we can do it later since this PR is quite large. MacOS works great! the web version is runnable but we still need to switch to another image source in order to bypass the CORS, we can make another PR to do that. I don't have a window machine at the moment so I can't test it out.

If anyone can take some screenshots of the app running on the window, that would be great! @Jesse-Lucas1996 Could you please add some screenshots of the app running on the web and desktop to the PR's description? Thanks!

Jesse-Lucas1996 commented 1 year ago

@hungps I sure can do that for you :) if you have discord or something or even talk here it'll be great to figure out that image source as well

Jesse-Lucas1996 commented 1 year ago

@hugovidafe Heyo! The theme changes do come from flutter being upgraded. This is the official change they recommended. It looks the same to me but don't take that at face value 😂

hungps commented 1 year ago

@Jesse-Lucas1996 I've mentioned about how to use the new image source in this issue. I still need to replace all imageurl from the data source with the new URL and bring the data source to flutter_pokedex_db so that everyone will be able to contribute. Let's do all that on another PR 😉

Jesse-Lucas1996 commented 1 year ago

@hungps have updated with pictures We might need to do a styling PR as well imo

hungps commented 1 year ago

@Jesse-Lucas1996 Agree! Responsive is required. We could limit the width of the app for now so that the layout won't break. flutter_web_frame looks promising 🤔

Jesse-Lucas1996 commented 1 year ago

@hungps I'm all or installing random things and pray that it works, should we merge this PR in then try that?

hungps commented 1 year ago

@Jesse-Lucas1996 Merged!