search

hungryinc / eloquent-oauth2-models

6 stars 0 forks source link

Hello #1

Open lucadegasperi opened 10 years ago

lucadegasperi commented 10 years ago

Hi, whoever maintains this repo :smile:

Just wanted to let you know there's another package for laravel that wraps around the php-loep oauth2-server library. https://github.com/lucadegasperi/oauth2-server-laravel this package has builtin models to help with the laravel implementation of the oauth2 server and much more.

Without writing code twice, I (as the maintainer of the other package) would ask you to join forces in building an awesome oauth2-server package for laravel.

Let me know what do you think :smile:

Luca

zacharyblank commented 10 years ago

Hey Luca,

Happy to join forces on this. I took a quick look at your package and noticed that there is a lot more involved in it. My approach was simply the Eloquent implementations of the interfaces from @alexbilbie's package. I wrote them awhile ago (7 months - https://github.com/zacharyblank/oauth2-server) and just not got around to organizing things here. My approach was not to make it for Laravel explicitly, rather for Eloquent. Would hate to have 2 packages of the same thing floating around. What do you think?

lucadegasperi commented 10 years ago

I think most of the people that use eloquent, also use laravel and enjoy its convenience. Also people can always extract only the interesting bits, as long as they are there.

Now, I would like to hear your opinion on how we can move forward. Did you perhaps had any plans in your mind for this package before I came along?

zacharyblank commented 10 years ago

Totally agree with you on the Laravel Eloquent piece. Your package is certainly more thorough than this one - can @alexbilbie and @philsturgeon comment on this?

lucadegasperi commented 10 years ago

As @philsturgeon (drunk or not) pointed out on twitter, one package (mine) could include the other (yours). They would live their own life and be maintained separately. What his reasoning doesn't take into account is the possible benefit for the end user of two (unknowns before a couple of minutes ago) joining forces and making choices together. Also there would be one stop-shop for all your eloquent+laravel+oauth2 needs. This is my opinion obviously and I would like to here yours as well.

lucadegasperi commented 10 years ago

Another option is to have a subtree split of the models part of my package, So that only the models can be required if needed. (just like laravel does with the illuminate packages).

philsturgeon commented 10 years ago

Why

Phil Sturgeon

On Monday, December 23, 2013 at 5:02 AM, Luca Degasperi wrote:

Another option is to have a subtree split of the models part of my package, So that only the models can be required if needed. (just like laravel does with the illuminate packages).

— Reply to this email directly or view it on GitHub (https://github.com/casserole/eloquent-oauth2-models/issues/1#issuecomment-31111473).